Conversation
travisdesell
requested changes
Oct 19, 2020
Owner
travisdesell
left a comment
travisdesell
left a comment
There was a problem hiding this comment.
"batch-size" is confusing because it means something else in the context of minibatch gradient descent or batch gradient descent. I would call it 'sequence_length' instead. Change 'batchify' to something like split_by_length or something as well to avoid confusion.
Edit pennchar to penn
editing path of testing files.
Added about work done this semester
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added the batch_size argument in the main function.